salt-formulas/salt-formula-docker

docker daemon configuration

Opened this issue · 3 comments

I would like to customize the docker daemon configuration through the /etc/docker/daemon.json file:
https://docs.docker.com/engine/reference/commandline/dockerd/#daemon-configuration-file

Would it be possible to update the way /etc/docker/daemon.json is created in docker/host.sls so that it would be simple the json serialization of the docker.host.daemon pillar? Something like:

/etc/docker/daemon.json:
  file.managed:
    - contents: |
        {{ host.daemon | json(indent=2) | indent(8) }}
  - require:
    - pkg: docker_packages
  - watch_in:
    - service: docker_service

Hello,
it would be possible (by creating structure by other pillars and merging these options in) however we don't like this approach (having common metadata to generate any configuration) mostly because of philosophical and testing reasons. It's better to add features that are needed separately and introduce specific metadata for them (eg. like in case of setting up insecure registries).
Anyway in this case it's a lot of options to implement separately so maybe it's worth considering this way.

I can prepare a pull request if you want

It would be great :-)