Formula crashes FreeIPA 4.6.8 on Salt 3004

[ggiesen]

Salt 3004.0 introduces a number of new options to random.get_str, most set by default. This includes punctuation characters, which seem to crash ipa-client-install. I recommend changing the OTP generation to not use punctuation characters, at least on Salt 3004.0. You can do this by changing (in freeipa/client/init.sls):

{%- set otp = salt['random.get_str'](20) %}

to:

{%- if salt['salt_version.greater_than']('Aluminium') %}
{%- set otp = salt['random.get_str'](length=20, punctuation=False) %}
{%- else %}
{%- set otp = salt['random.get_str'](20) %}
{%- endif %}

Also, the {{ otp }} tags are unescaped, and causes issues with some characters on the command line. I recommend surrounding them with single quotes. To do so, change:

-w {{ otp }}

and

-w {{ client.otp }}

to:

-w '{{ otp }}'

and

-w '{{ client.otp }}'

Documentation on the new options for random.get_str are available here.