salt-formulas/salt-formula-letsencrypt

[BUG] domain.sls should use the configured cli client

Cybso opened this issue · 0 comments

The certbot binary in letsencrypt/client/domain.sls is hardcoded but should use the configured cli binary instead. The patch is a one-liner, so please excuse me for keeping this bugreport compact and not making an elaborate pull request for it :-)

diff --git a/letsencrypt/client/domain.sls b/letsencrypt/client/domain.sls
index b7ab774..cab7b38 100644
--- a/letsencrypt/client/domain.sls
+++ b/letsencrypt/client/domain.sls
@@ -23,7 +23,7 @@
 certbot_{{ domain }}:
   cmd.run:
     - name: >
-        certbot certonly {{ staging }} --non-interactive --agree-tos --no-self-upgrade --email {{ params.email|default(client.email) }}
+        {{ client.source.cli }} certonly {{ staging }} --non-interactive --agree-tos --no-self-upgrade --email {{ params.email|default(client.email) }}
         {%- if auth.method == 'standalone' %}
         --standalone --preferred-challenges {{ auth.type }} --http-01-port {{ auth.port }}
         {%- elif auth.method == 'webroot' %}