[BUG] apache.config.vhosts.cleanup now remove the service

[Yoda-BZH]

Your setup

Formula commit hash / release tag

Using the states:

    - apache.config.debian_full
    - apache.config.modules.mod_geoip
    - apache.config.modules.mod_ssl
    - apache.config.modules.mod_remoteip
    - apache.config.modules.mod_mpm
    - apache.config
    - apache.modules
    - apache.config.manage_security
    - apache.config.vhosts.standard
    - apache.config.vhosts.cleanup
    - apache.config.logrotate

I was using apache.config.vhosts.cleanup to remove no-longer-declared vhosts from sites-enabled.

With 9d3e62c, the behaviour changed. It went from removing the vhosts and having the service still running, to remove the vhosts and removes the service.

It's a BC break for the feature, but the state is not documented.

is this a bc break?

Versions reports (master & minion)

Salt Version:
          Salt: 3004
 
Dependency Versions:
          cffi: Not Installed
      cherrypy: Not Installed
      dateutil: 2.7.3
     docker-py: Not Installed
         gitdb: Not Installed
     gitpython: Not Installed
        Jinja2: 2.10
       libgit2: Not Installed
      M2Crypto: 0.31.0
          Mako: Not Installed
       msgpack: 0.5.6
  msgpack-pure: Not Installed
  mysql-python: 1.3.10
     pycparser: Not Installed
      pycrypto: Not Installed
  pycryptodome: 3.6.1
        pygit2: Not Installed
        Python: 3.7.3 (default, Jan 22 2021, 20:04:44)
  python-gnupg: Not Installed
        PyYAML: 3.13
         PyZMQ: 17.1.2
         smmap: Not Installed
       timelib: Not Installed
       Tornado: 4.5.3
           ZMQ: 4.3.1
 
System Versions:
          dist: debian 10 buster
        locale: UTF-8
       machine: x86_64
       release: 4.19.0-18-amd64
        system: Linux
       version: Debian GNU/Linux 10 buster

Pillar / config used

states:
  list:
    - apache.config.debian_full
    - apache.config.modules.mod_geoip
    - apache.config.modules.mod_ssl
    - apache.config.modules.mod_remoteip
    - apache.config.modules.mod_mpm
    - apache.config
    - apache.modules
    - apache.config.manage_security
    - apache.config.vhosts.standard
    - apache.config.vhosts.cleanup
    - apache.config.logrotate

---

Bug details

Describe the bug

my-server # salt-call state.apply test=True
local:
----------
          ID: apache-service-clean-service-dead
    Function: service.dead
        Name: apache2
      Result: None
     Comment: Service apache2 is set to be killed
     Started: 15:09:20.140998
    Duration: 19.507 ms
     Changes:   

Summary for local
--------------
Succeeded: 978 (unchanged=2, changed=1)
Failed:      0
--------------
Total states run:     978
Total run time:    16.282 s

at the next run, the service would be reactivated.

Steps to reproduce the bug

Expected behaviour

Attempts to fix the bug

none.

Additional context

using pillarstack.

[Yoda-BZH]

liked to #372

[myii]

@Yoda-BZH Apologies for the breakage, that's been reset in #372, while provided a distinct clean SLS to cover that job as well (as discussed in Slack).

[saltstack-formulas-travis]

🎉 This issue has been resolved in version 1.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀