saltstack-formulas/packages-formula

RFE: Consider repo handling feature

noelmcloughlin opened this issue · 3 comments

Would it be in scope, for this formula, to remove list of unwanted repos? For example, apache formula adds a known bad repo so formula fails. This is OS annoyance but just recording this.

          ID: wanted_packages
    Function: pkg.installed
      Result: False
     Comment: An error was encountered while installing package(s): W: The repository 'http://httpredir.debian.org/debian xenial Release' does not have a Release file.
              E: Failed to fetch http://cdn-fastly.deb.debian.org/debian/dists/xenial/non-free/binary-amd64/Packages  404  Not Found [IP: 151.101.40.204 80]
              E: Failed to fetch http://cdn-fastly.deb.debian.org/debian/dists/xenial/non-free/binary-i386/Packages  404  Not Found [IP: 151.101.40.204 80]
              E: Failed to fetch http://cdn-fastly.deb.debian.org/debian/dists/xenial/non-free/binary-all/Packages  404  Not Found [IP: 151.101.40.204 80]
              E: Failed to fetch http://cdn-fastly.deb.debian.org/debian/dists/xenial/non-free/i18n/Translation-en  404  Not Found [IP: 151.101.40.204 80]
              E: Failed to fetch http://cdn-fastly.deb.debian.org/debian/dists/xenial/non-free/dep11/Components-amd64.yml  404  Not Found [IP: 151.101.40.204 80]
              E: Failed to fetch http://cdn-fastly.deb.debian.org/debian/dists/xenial/non-free/dep11/icons-64x64.tar  404  Not Found [IP: 151.101.40.204 80]
              E: Some index files failed to download. They have been ignored, or old ones used instead.

Personally, in that particular case, I think the proper thing to do is fix the apache formula, to do the 'right thing' (TM).

OTOH, many times some apps can be downloaded as system packages that just need to be installed (which is in the scope of this formula), but also provide a repo entry to keep the app updated (ie dropbox, azure-cli, google-talkplugin, spotify, etc.).

I think that adding in the pkgs.sls file, the possibilty to add such repo if desired would be a great additon.

wdyt?

Yeah, definitely sounds useful. There are probably many formulas trying to manage repo entries today. And it potentially would offer a centralized repo entry list management pillar. I haven't given much thought on this. Using this formula for 1st time today - it duplicates some "in-house" SLS that maybe could be retired.

Closing per discussion.