saltstack-formulas/salt-formula

Windows python 3 minion package has different name in salt-winrepo-ng

labmonkey42 opened this issue · 2 comments

In osfamilymap.yaml the salt-minion package is defined as salt-minion under Windows. However, winrepo-ng defines the python 3 package as salt-minion-py3 here.
When py_ver is defined as 'py3' applying salt.minion to a Windows minion complains that The following packages failed to install/update: salt-minion.

Expected:
Formula should install/update salt-minion-py3 package on Windows when py_ver: 'py3'.

Actual:
Formula attempts (and fails) to install/upgrade salt-minion package on Windows when py_ver: 'py3'.

To reproduce:
Install Py3 minion on Windows, apply salt.minion state to the minion with py_ver: 'py3' in salt pillar, observe pkg.installed failure with The following packages failed to install/update: salt-minion.

The fix suggested by @myii misses the core of the report.

The fix suggested by @myii misses the core of the report.

After discussion with @myii on Slack I have verified that the updated PR results in the appropriate behavior.