saltstack/salt-bootstrap

[BUG] Cannot install 3004 as branch was removed

Closed this issue · 5 comments

realulim commented

Description
Installation of Version 3004.1 fails, because branch was removed.

curl -o bootstrap-salt.sh -L https://bootstrap.saltstack.com
sudo sh bootstrap-salt.sh -x python3 -P git 3004.1

This gives the error message:

fatal: Remote branch 3004.1 not found in upstream origin

Setup
Rocky Linux 8 vanilla install

Please be as specific as possible and give set-up details.

  • VM running on a cloud service, please be explicit and add details

Additional context
Please advise on how to programmatically install Salt version 3004.x

git ls-remote --heads https://github.com/saltstack/salt.git shows that the branch was removed. I cannot install any newer version, because they will fail on Rocky Linux 8 due to #1883

welcome commented

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

whytewolf commented

3004.1 was never a branch.

the issue is that a while ago someone had changed the git functionality in bootstrap to not match the documentation. and the bootstrap would automatically assume anything tried was a tagged release. and would put v in front of all references. this is not how bootstrap was ever supposed to work. you are supposed to be able to use any references. not assume everything is in the tagged refs. this was corrected recently in the bootstrap when someone pointed out they couldn't install the 3006.x branch.

that is to say 3004.1 should be v3004.1 to match the tag which all version tags in salt have always used v.

realulim commented

I have tried your suggestion:

sudo sh bootstrap-salt.sh -x python3 -P git v3004.1

However, that didn't work either. While I did get past the error mentioned above, the installation script errored out later with this message:

*  INFO: Running install_rocky_linux_restart_daemons()
Job for salt-minion.service failed because the control process exited with error code.
See "systemctl status salt-minion.service" and "journalctl -xe" for details.
*  INFO: Running daemons_running()
* ERROR: salt-minion was not found running
* ERROR: Failed to run daemons_running()!!!
* ERROR: salt-minion was not found running. Pass '-D' to bootstrap-salt.sh when bootstrapping for additional debugging information...
realulim commented

Oops, sorry, I forgot to remove EPEL, which lead to version conflicts. For the benefit of others:

You need to uninstall EPEL and also any salt-minion packages, which may have come in via EPEL instead of the bootstrap script.

whytewolf commented

thank you for your update. looks like you got it solved. I"ll go ahead and close this now.