samkusin/clemens_iigs

Failed to load and save snapshots

Closed this issue · 2 comments

wyatt-wong commented

I found that sometimes the emulator failed to save and load a snapshot. Morever, I found that it also failed to load a previously imported disk image at all.

Please check if you can recover the snapshot that I attached to you.

Test.clemens-sav.zip

samkusin commented

I took a look at this snapshot. It looks like the save failed before any disks were serialized and not enough information is available to restore it. This type of bug should be able to be detected during the save process instead of during load.

The snapshot you sent does provide enough information to fix this occurrance in the next release.

samkusin commented

Snapshot de-serialization had issues with memory allocation that resulted in corrupted save files. The memory management in this area has been refactored in:

PR #111 and regressions were fixed in #113 and #114 .

Snapshots have been stable since then and will close this issue.