sammachin/node-red-contrib-ngrok

[REQUEST]Adding username/password

Closed this issue · 3 comments

cymplecy commented

Hi
@biglesp has done a blog on using ngrok and I tried it out - all good :)

https://bigl.es/friday-fun-sms-controlled-neopixels/

But, as you know, it does leave your Node-RED completey exposed if someone happens to find your url (unlikely in practice unless you pay and get a perm ngrok url)

but ... :)
I had a play running ngrok in terminal and if I launch like this
image

I can stick the username/password in the Nexmo settings and voila - we have security (well - as long as we use something different from admin/password of course :) )
image

So, any chance of adding in this as an option in your node? -Does the underlying ngrok lib support it?

Simon

sammachin commented

Hi @cymplecy
Interesting, I didn't know ngrok had that, it looks as if the underlying library does allow that to be set, however the only drawback here is that then all your webhooks would also have the same authentication in front of them, I'm slightly concerned this would create more problems for people to debug, I'll have a play around with this when I get some free time and see how easy it is to implement,

okhiroyuki commented

Hi @sammachin
Modifications have been made in this repository, including authentication options.

Can I make a pull request?

sammachin commented

Implemented in the 1.0.0 release using a PR from @kingkong123

Sorrt @okhiroyuki I missed your comment until I'd merged the previous PR, please take a look at the current master and if you can see any improvements submit a PR