[SUGGESTION] Allow clients to upload skin to server
Closed this issue · 8 comments
basically, if the client uses the clientside mod, they should beable to upload a skin that they have saved locally, to the server, where it is then stored in /config/fabrictailor/skins/<uuid>/<filename>.png
Which would then allow a /skin set user <list filenames that have been uploaded under your uuid> so the server could have skins stored for faster loading
By uploading the skin to the server, there might be some security issues ...
It might be better for the client to generate skin signatures & values and send them to server.
I'm against the idea of giving the client abilities to write a skin file. There's other solution (mirroring the server process on client and sending the needed data to server), which would be the best way imo.
I mean. Why are you against it? There are simple checks we can do before any data is written or actually parsed.
Array length, if it exceeds/is less than, the number of pixels in a skin, automatically fail,
If datasent to the server is not a string, fail,
If datasent could not be parsed as a skin, fail.
Giving client ability to essentially write images on disk is not needed in this case, that's why I'm against it. Client can upload the image to mineskin by itself and then send the generated skin data to server.
Well the main reason why I bring this up. Is there is a option from the clienside, and server command, to load a file from disk, which errors out when the client side mod shows a file selector.
the client side mod is mainly used on singleplayer worlds, where the player using the mod is running minecraft in the same directory as the integrated server itself (local minecraft in this case)