samolego/FabricTailor

[Feature] Warn about internet conection on `/skin set`

Opened this issue · 7 comments

Minecraft 1.20.4
Fabric Tailor 2.3.0

Upon entering this command with no internet connection, it will respond with:

Trying to set the skin ... Please wait.
Uploading skin. Please wait.
You have to provide URL, player's name or file of the skin you want.

Does work fine when having internet connection.

I'm playing on a local LAN with friends with no internet connection, using this mod to set our skins.

This mod doesn't change skin fetching mechanic, it still uses mojang's system. So it needs internet access.

Ooh, I thought it wasn't supposed to be like that because of the respond message. It also delayed few seconds before displaying "You have to provide URL, player's name or file of the skin you want." like it is actually doing something. 🤔

Maybe change the error message to indicate that this mod doesn't work without internet connection?

It's doing something but fails to do it ... error mesaage is pretty generic, yeah.
Probably shows some info in logs?

Yeah, that would be better

the error still pops up even with internet connection

imgur and other servers show same error