Please use CSS for proper RTL support
Closed this issue · 0 comments
elad commented
Hi,
The code has this:
ColumnConfiguration.prototype.renderSorting = function(element) {
...
icon = angular.element("<i style='margin-left: 10px;'></i>");
...
Which means it doesn't support right-to-left (RTL) layouts for no good reason. :/
There are other embedded styles and icon classes, e.g. glyphicon glyphicon-chevron-down
, which (unless I'm missing something) goes against the statement on the project page:
This directive depends on angular only. No jQuery or Bootstrap required! It has been tested on angular 1.2, but it should also work with 1.1 releases.
Since I believe that styling should be decided by the developer, not the library, I'd like to know if you'd be open to a pull request that:
- Adds a CSS file and uses classes instead of embedded styles,
- Adds right-to-left support
- Allows specifying custom icon classes