Problems with library all over the place
Closed this issue · 3 comments
Constructor sets defaults for payment gateway, though tries to throw exception if nothing provided.
ErrorException doesn't exist (I think you want Exception).
Been looking for an eway library, but I don't think this is it - it needs a lot of work.
To be honest, I have not actually worked (or looked) at this in a while since the company I work for tends to put clients onto different gateways (usually the bank ones.)
I wrote this because I was concerned about the state of the existing PHP libraries for eway. With the benefit of hindsight, i would separate out the concerns of the gateway and the payment object (as well as have proper tests).
All well and good - though tbh I would test libraries a bit more before releasing them into the wild. The missing classes is a pretty blatant mishap.
Not quite a missing class, just a missing line of code.