samwightt/chorale

Add proper image support

Closed this issue · 3 comments

samwightt commented

While images work right now, they don't render properly. Things that need to be done:

  • Images need to be centered.
  • Images need to be resized according to the size given from the Notion API.
  • Images need to be lazily loaded
  • Images need to have alt content and captions added.
  • Page cover images need to be supported.
  • Images need a placeholder while lazily loading.
michello commented

@samwightt Hiya! Would love to help out if you don't mind. :)

samwightt commented

Sure, that's totally fine! It's been a minute since I touched this repo, but my work (as far as I can remember) on lazy loading images was in the feat/add-lazyload-image branch (see #10). Feel free to look at that and add any other stuff you want!

samwightt commented

Hey @michello is there any update on this?