feat: supply play services version during installation
Closed this issue · 2 comments
I would like to submit a PR to add a feature where the user can supply the play services version to match their other plugin dependencies.
Unfortunately, with the +, my android build was breaking due to dependency on gcm version 11.8.0 in cordova-plugin-googleplus. I've tried to use cordova-android-play-services-gradle-release to pin the version but for some reason it does not override the version in this plugin, and moreover it breaks my other plugin phonegap-plugin-push 😃. Welcome to the world of cordova where plugins keep wrestling with each other 😏
My errors
Error message
Found com.google.android.gms:play-services-base:+, but version 11.8.0 is needed for the google-services plugin.
Found com.google.android.gms:play-services-gcm:+, but version 11.8.0 is needed for the google-services plugin.
:processDebugGoogleServices FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':processDebugGoogleServices'.
> Please fix the version conflict either by updating the version of the google-services plugin (information about the latest version is available at https://bintray.com/android/android-tools/com.google.gms.googl
e-services/) or updating the version of com.google.android.gms to 11.8.0.
I believe this fix would offer more flexibility to developers and reduce the dependency on another versioning plugin if it's not required.
If the user does not supply a variable. it would take the + and it should work as expected as per the existing code.
PR #88
👍
i'm not sure why + would collide with 11.8.0 (or any version) but anyway i'm more than happy to merge in any PR that adds more configurability 😄
tryout 4.3.0 ! thanks again for contribution, every little bit helps