san650/ember-web-app

Can't use absolute urls for icons on ios

oscarni opened this issue · 2 comments

oscarni commented

When I specify icons with an absolute url in the manifest they render with a prefixed / for apple meta tags.

I have this in manifest.js:

icons: [
    {
      src: 'https://website.com/image/upload/123/icon-192.png',
      sizes: '192x192',
      type: 'image/png'
    }
]

The manifest file would be correct:

"icons": [
  {
    "src": "https://website.com/image/upload/123/icon-192.png",
    "sizes": "192x192",
    "type": "image/png"
  }
]

But the apple tags would look like this:

<link rel="apple-touch-icon" href="/https://website.com/image/upload/123/icon-192.png" sizes="192x192">

href="/ the slash can't be at the beginning of the url.. 😕

san650 commented

Thanks for reporting this, I'll try to fix it as soon as I have a bit of free time.

  • 👍1
san650 commented

@oscarni I've just released v1.3.1 with the fix. Thank you for tackling this!

See https://github.com/san650/ember-web-app/releases/tag/v1.3.1

  • 🎉1