FullBuild.xlam disaligned with srcWindow.cls

[6DiegoDiego9]

In FullBuild.xlam I get an error on the line "RectClient = rect" because RectClient is read-only (true, since it has no letter proc.)

Public Property Let RectByType(Optional iClWnd As EWndRectType, ByVal rect As Variant)
  Select Case iClWnd
    Case EWndRectType.RectTypeClient
      RectClient = rect
    Case EWndRectType.RectTypeWindow
      RectWindow = rect
  End Select
End Property

However, src\stdWindow.cls has "RectWindow = rect" in its place.

I'm new to your repository. Should I always take the src files as the latest version?

[sancarn]

because RectClient is read-only (true, since it has no letter proc.)

Ah yes, sorry, that is a WIP feature which I've since actually just added an error in place

I'm new to your repository. Should I always take the src files as the latest version?

Before raising an issue it would likely be good to try downloading the repo again yeah. I'm making fixes and changes all the time. Unfortunately I don't have a means of updating the library classes on demand (yet) :)

[6DiegoDiego9]

I see, however even after I replaced all the classes of FullBuild.xlam with the src*.cls, I still get errors:

I corrected(?) by removing the parenthesis and adding an "s".

[sancarn]

Thanks I'll go through and fix the compile errors. I haven't touched stdError in a long time.

Hope you find the library useful. Typically I don't add all modules into my projects, as they add a lot of clutter. Very few modules rely on eachother being around. So I'd only import the ones you need into your own projects :)

[6DiegoDiego9]

Thanks for the fixes 👍
I'm just giving a look at everything for the first time, to evaluate hands-on what to keep and discard.
What if I'll want to contribute with some work on some selected libraries? if you work on them offline for days, it would be risky...

[sancarn]

if you work on them offline for days, it would be risky

Whenever I make a change usually I commit straight away, although sometimes features are in planning for a while. Git sorts most of the conflicts out and I will likely have to help you through your first Pull Request, but that's fine and something I'm happy to do so long as it fits in with the strategy of the project :). Might be worth raising an issue with any ideas you want to implement first or taking something from the existing roadmap if any peak your fancy :)

What if I'll want to contribute with some work on some selected libraries

If you do want to make a change or an addition:

1. Make a branch of the repository.
2. Make any changes / additions you want to make to your own branch.
3. Create a "Pull Request"
4. We'll resolve any conflicts together
5. And if all goes well I'll approve it into the library.

If you have any specific

[sancarn]

Closing this as issues fixed