sandeepmistry/arduino-LoRa

Private declarations that should be public in LoRa.h

NicHub opened this issue · 1 comments

NicHub commented

In LoRa.h, are you sure you want the declarations from lines¹ 97 to 115 to be private? I especially need readRegister to be public but the other declarations can also be useful for end users.

¹ Line numbers of version 0.8.0 on PlatformIO:
https://registry.platformio.org/libraries/sandeepmistry/LoRa/versions

Kongduino commented

Indeed. I move manually read/writeRegister to public...

  • 👍1