We should add `vagrant-spk unpack`

Question

We should add `vagrant-spk unpack`

ocdtrekkie opened this issue 5 years ago · 4 comments

The spk unpack command mostly exists for Sandstorm itself to install an app. However, we should ensure that it is available to developers on Windows/Mac as well by supporting a vagrant-spk unpack command. A particular interest here is that a user may wish to grab old binaries out of an old SPK or may wish to swap out components of an existing SPK and repack it.

So we should ensure the flow of vagrant-spk unpack -> vagrant-spk vm up -> vagrant-spk dev -> vagrant-spk pack is a workable flow for this.

Related discussion sandstorm-io/sandstorm#3391 (comment)

Answer 1 · 2020-07-22T22:08:01.000Z

@zenhack confirmed a fear I had, that the build scripts are not included in the SPK.

I think we should fix that as part of this issue. Build scripts are super small and it would be good if the required information exists in an SPK to unpack it and then pack it again easily.

Answer 2 · 2020-07-22T22:20:14.000Z

It seems like this might be hard to do automatically; what files are part of the build scripts? If we only include build.sh & setup.sh, any helper scripts, Makefiles, etc. that are necessary may not be included. Quoting Jacob Weisz (2020-07-22 18:08:16)

…

***@***.*** confirmed a fear I had, that the build scripts are not included in the SPK. I think we should fix that as part of this issue. Build scripts are super small and it would be good if the required information exists in an SPK to unpack it and then pack it again easily. -- You are receiving this because you were mentioned. Reply to this email directly, [2]view it on GitHub, or [3]unsubscribe. Verweise 1. https://github.com/zenhack 2. #274 (comment) 3. https://github.com/notifications/unsubscribe-auth/AAGXYPQJG2B5I765CR4WZE3R45PNBANCNFSM4PE6EVMA

Answer 3 · 2020-07-22T22:50:20.000Z

I feel like if we have the .sandstorm folder we should have most of it for most apps? At minimum, it'll put one in a good position to know what they're missing. (Of course, the only scenario you likely need to hunt down someone and ask for what's missing is if it's a proprietary app.)

Answer 4 · 2020-07-22T23:22:45.000Z

That's probably not a bad default. Quoting Jacob Weisz (2020-07-22 18:50:35)

…

I feel like if we have the .sandstorm folder we should have most of it for most apps? At minimum, it'll put one in a good position to know what they're missing. (Of course, the only scenario you likely need to hunt down someone and ask for what's missing is if it's a proprietary app.)