santhosh-tekuri/jsonschema

Panics are bad :(

Closed this issue · 7 comments

danielfireman commented

Hi! Thanks for the great library!

I started changing datapackage-go to use jsonschema and stumbled upon a panic at jsonType. That might datapackage users to crash their program, which might not be what we want.

Would that be possible to remove it (returning an error or setting a default)?

Thanks!

santhosh-tekuri commented

the panic you mentioned, only happens if jsonschema.ValidateInterface(interface{}) is used and the
value passed contains invalid json value.

for example datapackage-gojsonschema.go can cause panic if map contains any struct value

santhosh-tekuri commented

as per the documentation of jsonschema.ValidateInterface(doc interface{}):

the doc must be the value decoded by json package using interface{} type.

santhosh-tekuri commented

seems you are expecting it validate any interface{} passed.

danielfireman commented

If possible, instead of panicking, I would rather return an error if it the schema is invalid.

danielfireman commented

Thanks for the fixing it quickly!

santhosh-tekuri commented

Please consider starring the project