santigimeno/node-uinput

warning: ‘bool v8::Object::ForceSet(v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’ is deprecated

hadrien-toma opened this issue · 2 comments

When I npm install uinput, this is the logs I get:

> uinput@1.1.0 install /home/hadrien-toma/dev/uinput-test/node_modules/uinput
> node-gyp rebuild

make: Entering directory '/home/hadrien-toma/dev/uinput-test/node_modules/uinput/build'
  CXX(target) Release/obj.target/uinput/src/uinput.o
  SOLINK_MODULE(target) Release/obj.target/uinput.node
  COPY Release/uinput.node
make: Leaving directory '/home/hadrien-toma/dev/uinput-test/node_modules/uinput/build'

> ioctl@1.0.1 install /home/hadrien-toma/dev/uinput-test/node_modules/ioctl
> node-gyp rebuild

make: Entering directory '/home/hadrien-toma/dev/uinput-test/node_modules/ioctl/build'
  CXX(target) Release/obj.target/ioctl/src/ioctl.o
  SOLINK_MODULE(target) Release/obj.target/ioctl.node
  COPY Release/ioctl.node
make: Leaving directory '/home/hadrien-toma/dev/uinput-test/node_modules/ioctl/build'

> ref@1.1.3 install /home/hadrien-toma/dev/uinput-test/node_modules/ref
> node-gyp rebuild

make: Entering directory '/home/hadrien-toma/dev/uinput-test/node_modules/ref/build'
  CXX(target) Release/obj.target/binding/src/binding.o
../src/binding.cc: In function ‘void init(Nan::ADDON_REGISTER_FUNCTION_ARGS_TYPE)’:
../src/binding.cc:619:182: warning: ‘bool v8::Object::ForceSet(v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’ is deprecated: Use CreateDataProperty / DefineOwnProperty [-Wdeprecated-declarations]
 cked(), Nan::New<v8::String>(CheckEndianness()).ToLocalChecked(), static_cast<PropertyAttribute>(ReadOnly|DontDelete));
                                                                                                                      ^
In file included from /home/hadrien-toma/.node-gyp/8.1.3/include/node/v8.h:26:0,
                 from /home/hadrien-toma/.node-gyp/8.1.3/include/node/node.h:63,
                 from ../src/binding.cc:6:
/home/hadrien-toma/.node-gyp/8.1.3/include/node/v8.h:2950:22: note: declared here
                 bool ForceSet(Local<Value> key, Local<Value> value,
                      ^
/home/hadrien-toma/.node-gyp/8.1.3/include/node/v8config.h:329:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^
../src/binding.cc:620:137: warning: ‘bool v8::Object::ForceSet(v8::Local<v8::Value>, v8::Local<v8::Value>, v8::PropertyAttribute)’ is deprecated: Use CreateDataProperty / DefineOwnProperty [-Wdeprecated-declarations]
 Nan::New<v8::String>("NULL").ToLocalChecked(), WrapNullPointer(), static_cast<PropertyAttribute>(ReadOnly|DontDelete));
                                                                                                                      ^
In file included from /home/hadrien-toma/.node-gyp/8.1.3/include/node/v8.h:26:0,
                 from /home/hadrien-toma/.node-gyp/8.1.3/include/node/node.h:63,
                 from ../src/binding.cc:6:
/home/hadrien-toma/.node-gyp/8.1.3/include/node/v8.h:2950:22: note: declared here
                 bool ForceSet(Local<Value> key, Local<Value> value,
                      ^
/home/hadrien-toma/.node-gyp/8.1.3/include/node/v8config.h:329:3: note: in definition of macro ‘V8_DEPRECATED’
   declarator __attribute__((deprecated(message)))
   ^
  SOLINK_MODULE(target) Release/obj.target/binding.node
  COPY Release/binding.node
make: Leaving directory '/home/hadrien-toma/dev/uinput-test/node_modules/ref/build'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN uinput-test@1.0.0 No description
npm WARN uinput-test@1.0.0 No repository field.

+ uinput@1.1.0
added 13 packages in 7.852s

My environment:

  • uname -srvio:
Linux 4.8.0-58-generic #63~16.04.1-Ubuntu SMP Mon Jun 26 18:08:51 UTC 2017 x86_64 GNU/Linux
  • npm --version:
5.0.3
  • nodejs --version:
v8.1.3

I hope that it is not too hard to fix.

DiThi commented

This warning is an error in node 9.

For some reason I missed this. I'll try to look into it soon. Thanks for the report!