sapphiredev/framework

@sapphire/framework does not declare @discordjs/builders in package.json dependencies

TymanWasTaken opened this issue · 0 comments

Is there an existing issue for this?

  • I have searched the existing issues

Description of the bug

While the package uses @discordjs/builders in the code, it is not declared in package.json, not only causing tools like yarn plug n play to break, but it's also just bad practice to use packages you don't actually declare as a dependency.

Steps To Reproduce

  1. Make a @sapphire/framework project using yarn plug n play
  2. Try to run
  3. See error
Error: @sapphire/framework tried to access @discordjs/builders, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: @discordjs/builders
Required by: @sapphire/framework@npm:3.0.0-next.080c438.0 (via [...])

Expected behavior

Framework declares all dependencies it uses in the package.json

Screenshots

No response

Additional context

No response