sarmbruster/grails-countries-plugin

default country names

Closed this issue · 4 comments

Deleted user commented

A lot of the country names in countries.csv look very unnatural to me. Examples include:

  • Brazil, Federative Republic of
  • Argentina, Argentine Republic
  • Luxembourg, Grand Duchy of

I'm not saying these are incorrect, but in everyday usage these countries are named:

  • Brazil
  • Argentina
  • Luxembourg

By contrast Ireland is listed as "Ireland" whereas the formal name is "The Republic of Ireland". So at the very least there's some inconsistency here.

I realise the user can change these names, but changing 250+ country names is not a trivial task and in my opinion the defaults should be more useful than they are at present. The overwhelming majority of applications would rather use country names like:

  • Brazil
  • Argentina
  • Luxembourg

rather than:

  • Brazil, Federative Republic of
  • Argentina, Argentine Republic
  • Luxembourg, Grand Duchy of
sarmbruster commented

do you think it would be sufficient to strip off everything after the first comma?

Deleted user commented

I think that would be a big improvement

sarmbruster commented

sorry, please disregard my previous comment.
The plugin uses only the first 4 columns of countries.csv to populate the database. Lookup for the name of a country happens by the countries resourcebundle in grails-app/i18n. Please verify that a sample app using <country:select name="myname"> returns the correct list of country names.

Deleted user commented

I had a look in the resource bundle and the names there look fine. I guess we can close this.