sarugaku/passa

Editable with markers cannot be handled correctly by Pipenv

Opened this issue · 1 comments

This is probably not a problem of Passa, but only a TODO when we eventually integrate Passa into Pipenv.

The problem is that Pipenv passes the line directly to pip, so say if you have

"foo": {
    "editable": true,
    "markers": "os_name == 'nt'",
    "path": "."
}

This becomes -e .; os_name == 'nt', and Pipenv would run pip like this

pip install -e ".; os_name == 'nt'"

The solution is probably to drop the markers completely from the line. They are not needed since Pipenv already evaluates them before running the pip command anyway.

investigating why these aren't handled downstream, will update