Additional text is added for ok and fail state
jxltom opened this issue · 3 comments
In pipenv, following is the result when locking is succeed.
➜ test pipenv lock
Locking [dev-packages] dependencies...
✔ Success! Locking...
Locking [packages] dependencies...
✔ Success! Locking...
Updated Pipfile.lock (8bdc9e)!
It looks like Locking... is additional.
Following text is better.
➜ test pipenv lock
Locking [dev-packages] dependencies...
✔ Success!
Locking [packages] dependencies...
✔ Success!
Updated Pipfile.lock (8bdc9e)!
My main reason was just to have text present during the process to let you know what’s going on
I agree. during the process, Locking... and etc should show up. But after the process is finished, I think probably it is better to only show the final results?
Especially in pipenv --python some_ver command, it will finally shows ✔ Complete Running... Running virtualenv with interpreter /home/user/.pyenv/versions/3.6.6/bin/python. It is a little bit confusing. Please have a look at the output for this command which is attached in the PR #36 (comment). Thanks.
Yep just looked it over, seems like a good change!