saucelabs/forwarder

http_proxy: remove ambiguity in connect headers configuration

mmatczuk opened this issue · 0 comments

This is a small refactoring that would remove the ambiguity in Martian configuration.

Plan:

  • Wrap header modifier in a layer that checks the HTTP method, for CONNECT use proxyHeaders, otherwise use requestHeaders
  • Remove ConnectRequestModifier in HTTPProxyConfig, martian.Proxy and dialvia
  • Add ProxyConnectHeader in dialvia and set it in Martian