savioxavier/repo-finder-bot

Command raised an exception: TypeError: argument of type 'NoneType' is not iterable

Closed this issue · 5 comments

mauvehed commented

So far this has only happened with my local instance of repo-finder-bot, specifically the one running from the Dockerfile I submitted in #15. Has anyone else seen this? You search for a repo and it throws an error from discord.py, you run the exact same search again and it succeeds. I've seen this a couple times so far but I've failed to catch the debug output from the container.

I'll try and post that here next time I see it.

image

V3ntus commented

It might be GitHub API not returning a proper response. If you can get a snapshot of the debug log when the error occurs, that might give some info. Although, because of how the log handler is programmed, I'm not sure if some information will be missing or not. That's on a TODO

  • 👍1
mauvehed commented

Yeah, I figured if anything this is a good thing to note the need for better exception handling from discord.py

  • 👍1
V3ntus commented

Yeah, I figured if anything this is a good thing to note the need for better exception handling from discord.py

Agreed. Probably some sort of retry function implementation? Either retry the HTTP query, or save some traffic and just reroll a random index value, that is assuming we got a response of usable results in the first place

Thanks for raising this issue 👍

mauvehed commented

I think I figured it out. Looks like my IPS was actively blocking connections to github.com at various times.

V3ntus commented

I think I figured it out. Looks like my IPS was actively blocking connections to github.com at various times.

Ah ok, glad you got it figured out!

I think we'd still like to implement some sort of retry feature to mitigate situations like that

  • 👍2