saz/puppet-sudo

update ::sudoversion to facts hash

Closed this issue · 3 comments

Need to fix ASAP:

2021-04-21T18:08:02.717-04:00 ERROR [qtp975700867-134] [puppetserver] Puppet Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, 'versioncmp' parameter 'a' expects a String value, got Undef (file: /etc/puppetlabs/code/environments/ENV/modules/sudo/manifests/conf.pp, line: 81, column: 9)

This might need a bit more information.
Can you specify some things like OS version, Puppet version, some specification on what you are trying to do?

saz commented

Legacy facts have been removed in master

v7.0.2 with Puppet 6.25.1

2021-12-06T13:53:18.204-05:00 ERROR [qtp2101420847-2734] [puppetserver] Puppet Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, 'versioncmp' parameter 'a' expects a String value, got Undef (file: /opt/puppetlabs/server/data/puppetserver/filesync/client/versioned-dirs/puppet-code/mapip_mapip_qa_v51c23f5_p0371758_j42_b0763e201c53ff9cb6b6fa4bfed6a319c6139a4f/thirdparty/sudo/manifests/conf.pp, line: 87, column: 9) (file: /opt/puppetlabs/server/data/puppetserver/filesync/client/versioned-dirs/puppet-code/mapip_mapip_qa_v51c23f5_p0371758_j42_b0763e201c53ff9cb6b6fa4bfed6a319c6139a4f/modules/profile_base/manifests/linux/sudo.pp, line: 7) on node nodename

profile_base::linux::sudo line 7 just says:

  7   sudo::conf {'admins':
  8     content  => '%admin ALL=(ALL) ALL',
  9     priority => 20,
 10   }

line 87 that it's complaining about is:

if (versioncmp($::sudoversion, '1.7.2p1') < 0) {