sbadia/puppet-gitlab

Dependency packages - switch to ensure_packages?

Closed this issue · 1 comments

When I try to use this gitlab module on my server, I am getting Package collisions with other modules. Would it be better to use stdlib's ensure_packages (which requires all modules' adoption), or would it be better to make each Package declaration happen in a separate module. A lot of discussion has been had about what method is better, and I'm not sure if I have a preference.

Example: Duplicate declaration: Package[libxml2-devel] is already declared; cannot redeclare at /etc/puppetlabs/puppet/modules/gitlab/manifests/pre.pp:61 on node gitlab-test

ensure_packages seems like a good though, but relying on other modules to implement or merge this seems optimistic.

The root issue is discussed in #35 a bit but we still haven't come to a solution. Once we get #62 completed and merged, I think this will be the next focus.