sbi-dev/sbi

`simulate_for_sbi` lives in `trainers`

michaeldeistler opened this issue · 4 comments

michaeldeistler commented

The path for simulate_for_sbi is odd, it lives in the trainers folder (in sbi.inference.trainers.base.py, although it can be imported from sbi.inference). We should probably move it to utils and then just import it in sbi.inference.__init__.py

samadpls commented

Hey @janfb, can I work on this issue?

  • 🚀2
janfb commented

Hey @samadpls yes, absolutely. Are you coming to the euroscipy sprint today or is it just coincident?

samadpls commented

Hey @samadpls yes, absolutely. Are you coming to the euroscipy sprint today or is it just coincident?

Hi, I think it's just a coincidence! I'm just contributing as an open-source contributor.

janfb commented

Ok cool!

Do you have a plan for fixing this, or do you need help with anything? Let me know 😊

  • 🚀1