sbi-dev/sbi

Refactor neural_nets model structure

Closed this issue · 3 comments

gmoss13 commented

After the new DensityEstimator interface is introduced, we have a confusing structure:

  • neural_nets.density_estimators should contain only one file for flows, containing all classes of flow-based density estimators
  • neural_nets.flow.py and neural_nets.mdn.py should be combined and the file should be explicitly named as a util file (containing only builder functions for flow-based density estimators. Potentially move this to utils.
fariedabuzaid commented

I can have a look into that.

  • 👍1
janfb commented

factory.py contains the meta build functions like posterior_nn etc, while we have individual files for the build_xyz(...) build functions, e.g., flow.py, mdn.py etc. This should be refactored into a more logically file structure.

janfb commented

closed with #1238 and #1237