sbooth/SFBPopovers

*** Assertion failure in + [NSView _findFirstKeyViewInDirection:forKeyLoopGroupingView:]

becknaum opened this issue · 5 comments

This was also an issue in the INPopoverController project.

According to that thread, this error sometimes arises when trying to enable keyboard access within a popover. It crashes the app on OS X 10.11 and previous. The only fix is to remove the contentView override accessor in SFBPopoverWindow.m.

I confirmed this fix in my project locally and can open a pull request for it as well.

I verified PR #9 fixes this issue.

I'm less certain if there would be any unintended side effects of the change. I think I'd prefer a fix where contentView was renamed to popoverContentView and is called explicitly.

Fixed in 40b683d

Has the pod been update to reflect this change? It looks like the pod is still 1.0.0 and I'm still having this issues.

Thanks for the support

Hey, I was wondering if the pod will ever be updated to include this change.

I updated the podspec to version 1.1.0