Only one room available when configuring room colors
Closed this issue · 13 comments
Checklist
- I have updated the integration to the latest version available
- I have checked if the problem is already reported
The problem
When changing room colors, only one option shows up for one room. The integration is reporting multiple segements (7). When adjusting this color, it didn't modify the floor color which I would have expected if there was an issue with segments/rooms. It correctly updated the color of the one room.
What version of an integration has described problem?
2024.6.0
What was the last working version of an integration?
No response
What vacuum model do you have problems with?
Roborock S5 Valetudo
Please firmware installed on your Vacuum.
2024.02.0
What type of platform you use?
VEMLinux (Virtual Machine) such as Proxmox, VMWare, etc.
What version of Home Assistant do you use?
core-2024.5.5
What type of installation are you running?
Home Assistant OS
Camera's settings.
No response
Logs or Errors shown in the HA snapshots (please enable the Debug Mode)
No response
Additional information
No response
@kevinduong is there any errors in the logs of HA?
I used an S5 too to check it pre-release. It is possible that the rooms data was not available. Can you please share the logs?
I'm not seeing anything in my HA logs that could relate to this. Something I did notice is that I don't have a .json that this line is looking for https://github.com/sca075/valetudo_vacuum_camera/pull/157/files#diff-7a92566dc654210611343ea0ef0fdceb787bc6d3351ad69afdf9704c89326774R27
That file should come with the rooms colours rename functions.. this is why probably I didn't get it in tests I've done.. sorry for that, I will fix it as soon. Thanks a lot @kevinduong.
No worries. Glad I could help out in some way. Thanks for spending the time to look into it.
Just for the record I'm having the same issue with my (new) installation.
Well currently we have a bigger problem to solve.. #161 but I promise I will do my best to fix this, as per there will be to reinstall the camera probably with the fix of #161. It feels really sad honestly... I found anyhow a lot of small imperfections and 2024.06.0 was released too early.. I had no time to fully test it. I admit the next will be not that better but I will do my best to keep it working.. as per it was designed.
No worries, thanks for building this and trying to fix things! :) Until fixes come out could I just roll back to the last version? I'm assuming that won't break anything.
Did release the 2024.06.1 hopefully this issue will be closed too by then. The release is locked as requires HA 2024.6.0.
You can although test it if you want, downloading the main, please note that common.py currently in use on the camera 2024.06.0 or earlier is the one you should keep when you want to test it. I could prepare a test release if needed,
Please do not forget to start the project if you didn't yet.
@kevinduong and @jgkawell I suppose by now you are aware that unfortunately the issue with users_data.py is persisting, I got also a validation error for the calibration_data (one of the two vacuums I have is with battery empty and this is creating this error).
Will review the code again as soon I'm done at work.
@kevinduong just one question the problem with rooms colours was then solved?
im a new user, 5 days since rooting and flashing valetudo on my dreame L10s ultra, im just joining in to say i never was able to see more than 1 rooms when i try to change room colours, i was hoping 2024.06.2 would fix this but no luck so far.
thx for this great integration!
@rj-d2 will change the default value and in the the next 2024.06.3b2 we can test if this works for you guys.
The issue was closed automatically because of the pull request merged few minutes ago. I will move it to discussions, please test the 2024.06.3b2 that will be published soon.