scaffold-eth/scaffold-eth-challenges

[Challenge 1] does the modifier notCompleted make sense?

samlaf opened this issue · 0 comments

In the it's a trap section:
image

is the notCompleted modifier really meant to protect execute and withdraw?
Don't we instead just want to protect stake to prevent more funds from being locked in?
Otherwise this seems to let people add in more funds, but then can't call execute nor withdraw anymore.