scala-ide/scala-refactoring

Race condition in TreeTransformers

dragos opened this issue · 2 comments

dragos commented

Log here.

allEmpty(scala.tools.refactoring.tests.transformation.TreeTransformationsTest)  Time elapsed: 0.015 sec  <<< FAILURE!
java.lang.AssertionError: assertion failed: Race condition detected: You are running a presentation compiler method outside the PC thread.[phase: <no phase>] Please file a ticket with the current stack trace at https://www.assembla.com/spaces/scala-ide/support/tickets
    at scala.tools.nsc.interactive.Global.assertCorrectThread(Global.scala:501)
    at scala.reflect.internal.Symbols$Symbol.rawInfo(Symbols.scala:1390)
    at scala.reflect.internal.Symbols$Symbol.info(Symbols.scala:1331)
    at scala.reflect.internal.Symbols$Symbol.tpeHK(Symbols.scala:1255)
    at scala.reflect.internal.Types$Type.computeMemberType(Types.scala:702)
    at scala.reflect.internal.Types$Type.memberType(Types.scala:699)
    at scala.reflect.internal.Types$class.defineUnderlyingOfSingleType(Types.scala:1418)
    at scala.reflect.internal.SymbolTable.defineUnderlyingOfSingleType(SymbolTable.scala:14)
    at scala.reflect.internal.Types$SingleType.underlying(Types.scala:1370)
    at scala.reflect.internal.Types$SimpleTypeProxy$class.isError(Types.scala:147)
    at scala.reflect.internal.Types$SingletonType.isError(Types.scala:1227)
    at scala.tools.refactoring.transformation.TreeTransformations$$anonfun$treesToTraversalFunction$1$TransformOnce$2$.once(TreeTransformations.scala:62)
    at scala.tools.refactoring.transformation.TreeTransformations$$anonfun$treesToTraversalFunction$1.apply(TreeTransformations.scala:69)
    at scala.tools.refactoring.transformation.TreeTransformations$$anonfun$treesToTraversalFunction$1.apply(TreeTransformations.scala:16)
    at scala.tools.refactoring.transformation.Transformations$$anon$4.apply(Transformations.scala:115)
    at scala.tools.refactoring.transformation.Transformations$$anon$4.apply(Transformations.scala:113)
    at scala.Option.flatMap(Option.scala:170)
    at scala.tools.refactoring.transformation.Transformations$Transformation$$anon$7.apply(Transformations.scala:38)
    at scala.tools.refactoring.transformation.Transformations$$anon$4$$anonfun$apply$2.apply(Transformations.scala:115)
    at scala.tools.refactoring.transformation.TreeTransformations$$anonfun$treesToTraversalFunction$1$TransformOnce$2$.transform(TreeTransformations.scala:66)
    at scala.tools.refactoring.transformation.TreeTransformations$$anonfun$treesToTraversalFunction$1$TransformOnce$2$.transform(TreeTransformations.scala:22)
    at scala.reflect.internal.Trees$class.itransform(Trees.scala:1359)
    at scala.reflect.internal.SymbolTable.itransform(SymbolTable.scala:14)
    at scala.reflect.internal.SymbolTable.itransform(SymbolTable.scala:14)
    at scala.reflect.api.Trees$Transformer.transform(Trees.scala:2624)
    at scala.tools.refactoring.transformation.TreeTransformations$$anonfun$treesToTraversalFunction$1$TransformOnce$2$.once(TreeTransformations.scala:64)
    at scala.tools.refactoring.transformation.TreeTransformations$$anonfun$treesToTraversalFunction$1.apply(TreeTransformations.scala:69)
    at scala.tools.refactoring.transformation.TreeTransformations$$anonfun$treesToTraversalFunction$1.apply(TreeTransformations.scala:16)
    at scala.tools.refactoring.transformation.Transformations$$anon$4.apply(Transformations.scala:115)
    at scala.tools.refactoring.transformation.Transformations$$anon$4.apply(Transformations.scala:113)
    at scala.Option.flatMap(Option.scala:170)
    at scala.tools.refactoring.transformation.Transformations$Transformation$$anon$7.apply(Transformations.scala:38)
    at scala.tools.refactoring.transformation.Transformations$Transformation$$anon$7.apply(Transformations.scala:38)
    at scala.tools.refactoring.tests.transformation.TreeTransformationsTest.allEmpty(TreeTransformationsTest.scala:58)
misto commented

Hi Iulian, I've fixed the race conditions, also the ones indicated by the latest build: https://jenkins.scala-ide.org:8496/jenkins/job/parameterized-refactoring/769/ Could you maybe trigger another build?

misto commented

I'm going to close this since these cases have been fixed.