scala-js/scala-js-dom

Should `opaque type`s subtype `String`?

Closed this issue · 6 comments

armanbilge commented

Came up in #592 (comment) but we deferred the decision.

japgolly commented

We can close this now, right @armanbilge ?

armanbilge commented

Actually not yet, we didn't make a decision on this since we can do it compatibly at a later stage. Would appreciate your insight here 😁

japgolly commented

Oh right. Went and read the comment. Yeah sounds good to me, is there any reason not subtype String?

  • 👍1
armanbilge commented

Don't think so! I can make a PR with this, but it doesn't have to block the RC.

japgolly commented

Actually it should only take a second. How about I regex up a PR and then cut an RC right after?

armanbilge commented

Go ahead! You're too fast for me 😆 🐌

  • 😄1