scala-js/scala-js-dom

Add `URLSearchParams` to `BodyInit` for fetch

armanbilge opened this issue · 3 comments

armanbilge commented

scala-js-dom/dom/src/main/scala/org/scalajs/dom/package.scala

Line 35 in e7254c8

Blob | BufferSource | FormData | String // todo: add URLSearchParams

zetashift commented

Shouldn't the scaladoc comment for BodyInit point to https://fetch.spec.whatwg.org/#bodyinit-unions ? At the very least the current link links to the ToC of the spec hehe.

Also is this issue really as easy as just adding URLSearchParams to the union?

armanbilge commented

Thanks, that seems better :)

Also is this issue really as easy as just adding URLSearchParams to the union?

Famous last words 😝 it should be, but I haven't checked if URLSearchParams exists at least 😂