scala-js/scala-js-dom

Fix crypto `new`-based constructors?

armanbilge opened this issue · 0 comments

Continuation of #624.

I "fixed" that one in #657 but only looked at Init types and neglected the many crypto types which turns out need the same treatment. I noticed this while reviewing #667.

This one is harder, because it seems that many of the members are actually required and not optional, as was generally the case for the Init types. So if we made this change, when used required members would be defined as vals but the optional ones would be set imperatively, which is a bit strange but maybe okay.

Source-breaking, once again, and possibly not worth it in this case. But in general I think the type signatures for crypto stuff need to be improved, so linking to #660.