Add Automatic-Module-Name to MANIFEST.INF to all modules
schrepfler opened this issue · 3 comments
In order to increase compatibility on JDK versions with modules consider adding Automatic-Module-Name in the MANIFEST.INF along the lines of akka/akka#23960 or perhaps even implement properly the module-info descriptor.
I've raised scala/scala-xml#367 scala/scala-collection-compat#263 scala/scala-java8-compat#168 scala/scala-collection-contrib#65 scala/scala-parallel-collections#82 and scala/scala-parser-combinators#248 as I wasn't aware of this project.
Here's how this was added to scala/scala: scala/scala#6395. I think the same should apply to modules.
Just a note, this will not be enough to address building with jlink (it seems) as it seems automodules aren’t supported/strict enough.
PR: #128, inspired by @makingthematrix's additional pressure at https://users.scala-lang.org/t/scala-jdk-11-and-jpms/6102/37