scala/scala-xml

Release 1.3.0

ashawley opened this issue · 19 comments

ashawley commented

There was a significant fix in #392 that seems worth making a release for.

There are also some small deprecations we should publicize.

Changes since 1.2.0:

v1.2.0...1.x

Draft release notes:

  • Fixes regression on Scala 2.13, issue #392, concerning the collections implementation for NodeSeq
  • Publish for Scala.js 1.0.0
  • Update Scala.js to 0.6.32
  • Update Scala to 2.12.10 and 2.13.1
  • Various unused public classes and methods are deprecated
    • Deprecate definitions under scala.xml.persistent
      • CachedFileStorage
      • Index
      • SetStorage
    • Deprecate scala.xml.dtd.impl.PointedHedgeExp
    • Deprecate scala.xml.dtd.Scanner
    • Deprecate scala.xml.dtd.ContentModelParser
    • Deprecate scala.xml.dtd.ElementValidator
    • Deprecate scala.xml.factory.Binder
    • Deprecate scala.xml.parsing.ValidatingMarkupHandler

The items deprecated above are already deleted in the 2.0.0-M1 milestone release, which see https://github.com/scala/scala-xml/blob/v2.0.0-M1/CHANGELOG.md

ashawley commented

I wonder if we should just wait for Scala.js 1.0? It should be coming out in a few days.

SethTisue commented

(as we were just discussing at #408 , I'd be content just doing a scala-xml 2.0.0 and at least provisionally just abandoning the scala-xml 1.x series)

ashawley commented

Unfortunately, I predict the Lift framework will more likely benefit from a 1.3.0 release than a 2.0 milestone: 1) Their build looks like it still supports Scala 2.11 and 2) They likely depend on parts of scala-xml that were deprecated and removed in 2.0 milestone.

  • 👍1
ashawley commented

I'll try to do my part to make a 1.3.0 release. If I hit a wall, I probably won't spin my wheels on it for long.

  • 👍1
ashawley commented

Various updates to the build in #411

ashawley commented

I've added draft release notes to this issue's description.

SethTisue commented

s/Publish Scala.js for/Publish for Scala.js/, otherwise LGTM

  • 👍1
ashawley commented

As predicted in #411, publishing from this old branch didn't work

$ admin/build.sh
Releasing 1.3.0 with Scala 2.13.1 on Java version 8.
iv undefined
The command "admin/build.sh" exited with 1.

I deleted the tag and will need to revisit.

ashawley commented

Looks like it is the openssl command in the build script:

K=$encrypted_6b8d67feaab7_key
IV=$encrypted_6b8d67feaab7_iv
openssl aes-256-cbc -K $K -iv $IV -in admin/secring.asc.enc -out admin/secring.asc -d

The $IV is empty.

lrytz commented

So the relevant changes to back-port seem to be

I'm happy to do it, as I also want to push the simplification discussed in #406 (comment) through all the module repos, but I won't have time within the next few days...

lrytz commented

#418 backports the build changes to 1.x

andreak commented

Any progress on the 1.3.0 release?
This is blocking us from using Lift with Scala-2.13...

ashawley commented

Lukas did the heavy lifting of fixing the build on the 1.x branch.

I've pushed a tag for 1.3.0:

https://travis-ci.org/github/scala/scala-xml/builds/663175069

Someone on the Scala team will have to publish.

andreak commented

Great!

SethTisue commented

artifacts are on their way to Maven Central

ashawley commented

Thanks, looks like they made it.

I'll work on pasting the release notes.