scala/scala-xml

Publish next release (to publish Scala 3 Native support)

SethTisue opened this issue · 15 comments

SethTisue commented

note that #592 made some build changes that haven't been tested yet in a releasing context, so this release should be done with some extra care

have any other changes been made since the last release? what should the new version number be?

SethTisue commented

here's auto-generated release notes for the proposed release.

@ashawley @dubinsky any opinion on whether these changes merit going to 2.1.0? or should we just call it 2.0.2?

What's Changed

New Contributors

Full Changelog: v2.0.1...v2.0.2

  • ❤️1
dubinsky commented

@ashawley @dubinsky any opinion on whether these changes merit going to 2.1.0? or should we just call it 2.0.2?

I think when my changes were reviewed @ashawley mentioned that they fit into 2.0.2...

catap commented

@SethTisue maybe move forward with it? This is a blocker for scalatest/scalatest#2097 which is blocking scalatests for scala-native for scala 3+

  • 👍1
SethTisue commented

better release notes:

What's Changed

  • Do not ignore XML comments when parsing by @dubinsky in #549
  • Do not ignore XML CDATA sections when parsing: by @dubinsky in #558
  • Parse nodes before and after the root element by @dubinsky in #560
  • Handle XML namespace declarations even when the underlying parser is … by @dubinsky in #587
  • Support Scala Native - Scala 3 by @lolgab in #592

Version Bumps

Internal

New Contributors

According to git shortlog -sn --no-merges v2.0.1.., 7 people contributed. Thank you Scala Steward, Aaron S. Hawley, Leonid Dubinsky, Seth Tisue, Julien Richard-Foy, Kenji Yoshida, Lorenzo Gabriele.

Full Changelog: v2.0.1...v2.0.2

SethTisue commented

a 2.0.2 release job failed with:

[error] Module scala-xml has an invalid version number: 2.0.2. You must increment the minor version number to publish a source incompatible release.
(https://github.com/scala/scala-xml/runs/5739371440?check_suite_focus=true#step:4:18)
[error] Module scala-xml has an invalid version number: 2.0.2. You must increment the minor version number to publish a source incompatible release.
(https://github.com/scala/scala-xml/runs/5739371440?check_suite_focus=true#step:4:19)
[error] Module scala-xml has an invalid version number: 2.0.2. You must increment the minor version number to publish a source incompatible release.
(https://github.com/scala/scala-xml/runs/5739371440?check_suite_focus=true#step:4:20)
[error] (xmlJS / versionCheck) Module scala-xml has an invalid version number: 2.0.2. You must increment the minor version number to publish a source incompatible release.
(https://github.com/scala/scala-xml/runs/5739371440?check_suite_focus=true#step:4:21)
[error] (xml / versionCheck) Module scala-xml has an invalid version number: 2.0.2. You must increment the minor version number to publish a source incompatible release.
(https://github.com/scala/scala-xml/runs/5739371440?check_suite_focus=true#step:4:22)
[error] (xmlNative / versionCheck) Module scala-xml has an invalid version number: 2.0.2. You must increment the minor version number to publish a source incompatible release.
(https://github.com/scala/scala-xml/runs/5739371440?check_suite_focus=true#step:4:23)
SethTisue commented

Volunteer to suggest what the appropriate solution is here and PR a fix...? I cannot spare the time this week or next.

nightscape commented

The lazy option would be to just bump to 2.1.0 😬
Would that hurt, except that people need to skim the release notes to see that nothing breaks with the upgrade?

catap commented

@nightscape an another way is switch ThisBuild / versionPolicyIntention to Compatibility.BinaryAndSourceCompatible but I don't think that it is good idea because it has remark that it shouldn't be switched back until 2.1.0 is released: https://github.com/scala/scala-xml/blob/main/build.sbt#L70

Thus, build.sbt contains a few hacks which should be removed for the next release and I've just upened a PR to do so: #598

@SethTisue any chance to release it as 2.1.0 what should unblock scalatests for scala3 at scala-native?

SethTisue commented

I'm happy to go along with whatever the consensus here appears to be. At the moment, #598 is failing CI, so that needs to be fixed first.

(I'm trying to minimize my involvement here to pushing whatever release tag y'all tell me to push — if another maintainer isn't available to push one theirselves, which would be my first choice. Any of y'all interested in joining the volunteer maintainer crew here?)

catap commented

@SethTisue to fix my branch you (or someone else) must to remove tag v2.0.2 from GitHub.

as soon as you did it, my PR should work

SethTisue commented

That I can do :-)

I deleted the tag and closed/reopened the PR which made the actions re-run, but isn't re-running the CircleCI jobs. I don't know anything about CircleCI (and since @ashawley has been a lot less active lately, maybe we should just remove that stuff, since he was the one managing it); perhaps you'll need to push a commit with a different hash in order to make that part re-run.

catap commented

@SethTisue base on that is failed in #598 I believe that now you must release 2.1.0 without this PR. Can you try? It should be releassed fine.

As soon as 2.1.0 is here I'll rebases my PR and it should pass the test.

(Checks and versioning and release process of scala-xml quite ugly and wired to be honest)

SethTisue commented

https://github.com/scala/scala-xml/releases/tag/v2.1.0, publish job at https://github.com/scala/scala-xml/actions/runs/2088914876

(Checks and versioning and release process of scala-xml quite ugly and wired to be honest)

Release process seems clean to me, courtesy of sbt-ci-release; a maintainer (currently @ashawley or I) just pushes a tag, done. But if you have specific suggestions, perhaps they'd be accepted.

As for the checks and versioning aspect, that's coming directly from https://github.com/scalacenter/sbt-version-policy, unless you see some repo-specific aspect here in this repo that could be improved. If it's about sbt-version-policy, you might consider lodging that feedback as one or more tickets there. (cc @julienrf)

catap commented

@SethTisue I see.

I mean that mix sbt-version-policy and versioning from git's tag with introducing supporting of scala 3 at scala-native creates sort of mess.

Anyway, now it should be much better.

  • 👍1