scarlehoff/pyHepGrid

Fix or remove broken function

Closed this issue · 1 comments

Follow up on f7ba0fc

def _check_numeric(self):
""" Asserts that runcard elements that need to be numeric indeed are """
# FIXME runcard_linecode is not specified.
# Where is it coming from? What is this doing?
# This complete functio is never called. Can it go?
for i in numeric_ids:
try:
float(self.runcard_dict[runcard_linecode[i]]) # noqa
except BaseException:
self.critical("Line {0} [{1}] should be numeric type. "
"Value is instead {2}.".format(
i, runcard_linecode[i], # noqa
self.runcard_dict[runcard_linecode[i]])) # noqa
print(self.logger)

Is broken (runcard_linecode is undefined) and never called. @jcwhitehead do you know what's going on? Can we remove the function?

Hangover from previous version - fine to remove. I'll fix it later today if you don't get around to it first!