The app doesn't run well after the Java rewrite

Question

The app doesn't run well after the Java rewrite

Closed this issue 2 years ago · 5 comments

We were using this app in https://github.com/PyTorchLightning/pytorch-lightning and it was working flawlessly.

Around February, we started noticing that the job wasn't running or updating on some PRs. Coincidentally this was just after this commit: bf07889

Is there any way we can use the previous version? Have you noticed these issues yourself? Since it's an app, we don't have access to any logs but it should be easy to reproduce.

We had to remove the required check from the CI for this reason.

Thank you for your help.

akihironitta commented 2 years ago

cc @Borda

👀2

Answer 1 · 2022-04-08T15:45:56.000Z

I can have a look at the logs. But I haven't noticed any issues on my projects. Any examples of issues where you had problems?

Answer 2 · 2022-04-08T15:48:00.000Z

For example, this PR which I just opened Lightning-AI/pytorch-lightning#12672

Answer 3 · 2022-04-08T16:10:48.000Z

It looks like it fails to decode the JSON of your PR. It seems to have problem with the auto-merge section. I will have a look to see what is the issue over the weekend.

Answer 4 · 2022-04-10T14:05:02.000Z

Ok, I fixed the issue, it looks like the native build of the Java app did not include the AutoMerge class properly. So when you enabled Auto Merge on your PRs, it failed to handle it. The new version is now deployed, so please give it a try and let me know if you see some more issues. Thanks.