schrepfler/puppet-jdk_oracle

package wget undefined even though its required

viper233 opened this issue · 7 comments

The package wget is required though not defined anywhere.

Does this module require other modules? I'm running this module alone.

Error message.

Error: Failed to apply catalog: Could not find dependency Package[wget] for Exec[get_jdk_installer] at /etc/puppet/modules/jdk_oracle/manifests/init.pp:47

Hi Viper, wget is definitely a required package. Still not too versed in puppet, I think if I specifically add a package wget on the class it should resolve it.

eg.
package { 'wget':
ensure => present,
}

Thanks for the prompt reply. I tried that and then it asked for the Yum class.. I'll talk to my colleagues who are a bit more familiar with puppet and see what I can come up with.

We can probably declare that as well although I think puppet should be able to map a generic package onto any package manager (anyhow, this module is rpm specific, probably we should declare rpm explicitly as well).

I forked the original repo and submitted a pull request with the change you suggested above.

https://github.com/Cinderhaze/puppet-jdk_oracle

That makes sense - I've been using this module from another which already pulls in wget so didn't see the issue.

fixed.