addon reloads discarded tabs
Opened this issue · 19 comments
Hello!
from addon's changelog:
2.0.2
Improvement
Now reloading twitch on addon installation and on addon update to ensure proper functionality
the problem is that the addon reloads not only "normal" live tabs, but all discarded (not loaded/unloaded with an addon like Auto Tabs Discard) tabs as well. that even crashed my browser the first time it happened :)
could you please add a check for loaded state of tabs?
Hi, thank you for the report, didn't know that something like that exists 😅
Will add that check in the next patch. Might take until the end of week or something as I am currently reworking some core features of the addon.
no problem! fortunately it doesn't happen frequently :)
...btw, do you accept feature requests?
Sure, but i cant give you an eta on the implementation 😅
Patch should be rolled out soon, lmk if the crash on tab reload is fixed. I am now checking if the tab is in discarded state
as of version 3.1.1 there were no crashes so far, thanks for the fix :)
However, I noticed some kind of a gradually developing recurring memory leak/drive thrashing, can't say yet for sure if it's related though, but rolling back the addon to v2 seemed to help.
as for feature requests, I saw that some of them are already implemented :D
not sure if it even worth to open another issue, so here goes:
- a countdown of sorts would be nice to see, not just a plain % progress bar. something like "~1h 30m remaining" at each drop. it would greatly help to comprehend the ETA and maybe set up a timer or something.
- a notification of some sort, indicating the current stream has ended/game changed and drop is no longer in progress. my rather common use case is muting the twitch tab and setting an external timer, and it's easy to lose quite some progress with longer drops with a casually playing streamer if there's no indication at all.
- an option to turn off/on heavy polling/stats display. I have a feeling that aforementioned memory issue is caused by that new feature that shows all the completed drops and stuff. recently twitch kinda fixed their inventory page, at least it became noticeably better. not even kidding you - trying to load it with big enough number of drops last year on Firefox would grind your browser to a halt, sometimes for several minutes! and trying to do the same on a any Chromium-based browser would simply crash it, even when available memory is relatively in abundance. :D If you can make that page replacement in your addon as light-weight as possible, please consider doing so :)
Will look into the performance issues first and then start work on the improvements!
Will ping you when the update is rolling out.
Thank you for reporting this. I did not notice the performance thing, apparently i am not using twitch enough myself :D
Just a heads up, i think i successfully elminated one source of active polling. I think that should already drastically improve the performance . Currently testing if I can even eliminate others aswell.
expecting to ship the update sometime next week
Got some disgusting css things to fix, might upload the new version tomorrow :)New update is now rolling out, lmk if there are any more issues :)
working OK so far, didn't notice any big performance hits since the last update. :) big thanks for the update!
other notes:
saw a cropped timer once, similar to a pic above, but with the time counter text completely cut off by the popup's lower edge (can't scroll down any more to reveal it). happened to the last icon of 3 to 5 drops game (was not a single row case, the scroll bar was active). couldn't reproduce since, unfortunately.
how to use "force notification" option? I thought it's supposed to turn on the "stream offline" notification automatically, but seems to not be the case?
also, is the notification popup just appear for a short time and am I simply missing it every time? I only saw it trigger once, when I was deliberately looking for the stream ending. is it possible to control popup display duration? or maybe it's better to show it every X minutes as a workaround for that limitation?
is it possible to keep the timer running "offline" and only correct/update online once in a while (every 5 minutes currently IIRC)? I mean, in its current form it's not going to show correct time left 99% of the time :D
or is it too performance-taxing? there's no need for precise timing either, just correct minutes left should be enough.
very low priority things:
- firefox containers/incognito compatibility (it kinda works already, but sometimes is confused as to which container's context to show) :)
- dark theme/following the browser setting
As commented on the other issue, will try to upload an fix for the missing data in the popup.
Regarding the "Force stream offline" Notification: As soon as this option is enabled, it should fire notification whenever a stream goes offline. It does not care wether the button in the player was enabled or disabled.
Sadly i have not found a way to change how long a notification is shown on screen. This is fully managed by firefox and/or the operating system. I think the default display time is somewhere around 5-10 seconds.
I could try to implement a "Read notification" System that resends notification until the user checkmarks it?
Yes, that should be possible, will try computing a "fake time left" until the next real refresh
ah, ok :) is the token required for addon to claim drops or only for displaying data in the popup?
well, I can't reliably remember if it was possible at all, but I think I saw some addon making popups that stayed for longer, but maybe it was before the total engine overhaul. still, IMO periodical popups should be a good enough workaround.
Just submitted the quick fix for the expired token. Was the number 1 prio as this might have impact on the entire extension. New version now gets reviewd by mozilla and should be online in the next few hours :)
Well.. that was an quick approval 😀 rollout should be starting now!
Investigating further, got some hickups here and there that didnt occur on my work machine. but should not have impact on claiming i think. will keep updated here
Would you mind further explanation on the container thing you mentioned?
Just letting you know that I think I got the "intermediate progress" calculation working. Might publish the update coming weekend @Tallefer
Looks like it's working mostly as intended, thanks a bunch! :)
Would you mind further explanation on the container thing you mentioned?
Sure! It's this thing: https://github.com/mozilla/multi-account-containers#readme
The potential issue arises when you open several twitch tabs at once in different containers/incognito, then the addon has to choose somehow which tab's progress to show :) Since you can open the popup from any other tab, not just twitch, it complicates things.
Just submitted the quick fix for the expired token. Was the number 1 prio as this might have impact on the entire extension. New version now gets reviewd by mozilla and should be online in the next few hours :)
Sometimes it still breaks and shows nothing for a while, but then "unbreaks", is that normal? Does it refresh the token on auto now? Also, for some reason it happens on World of Warships streams more than on any others, but that could be just a coincidence ofc.
Oh, and about the offline notification popup times: I just suddenly glanced at the toolbar and... now the solution looks quite obvious IMO :)
