Code attribution to MolSkill
josejimenezluna opened this issue · 1 comments
josejimenezluna commented
Hi @rneeser, many thanks for open-sourcing this!
I've noticed that many of the parts of the repo contain very few modifications from more or less equivalent code available on MolSkill, (e.g. fsscore scorer vs molskill scorer).
While MolSkill is MIT-licensed, it would be nice if you added comments in the files/functions/classes that were adapted from or inspired by it. Something like:
# adapted from (link from molskill repo)
Thanks!
rneeser commented
Hi @josejimenezluna!
Thanks for pointing this out! I added the code contribution remarks where it was missing so far. Let me know if you have more questions!
Thanks!