specifying the type on add-or-remove-column
Opened this issue · 3 comments
daslu commented
Currently (checked with a067803), it is possible to specify the type of a new column using a call to dtype-next
.
(-> {:x [1 2]}
(tablecloth.api/dataset)
(tablecloth.api/add-or-replace-column
:y (tech.v3.datatype/as-reader [1 2] :float32))
:y)
#tech.v3.dataset.column<float32>[2]
:y
[1.000, 2.000, ]
It could be nice to allow that directly as an option of the tablecloth
API, without requiring the user to know what a "reader" is.
genmeblog commented
Definitely user shouldn't know about the reader. There is a function for explicit datatype conversion (convert-types
) which can be called after insterting a column.
To enable add-or-remove-column
probably API should be changed to accept a map as the last parameter. Currently it contains size-strategy
. We need to think how to avoid breaking change here.
ashimapanjwani commented
@genmeblog Can I pick this up?
genmeblog commented
Yes! Thanks.