Asymptotic calculator histogram dimensionality
CrfzdPQM6 opened this issue · 4 comments
When generating the asimov histogram associated with a particular test, why is the generated histogram limited to a one-dimensional fit, implicitly by the call to space.limit1d
here? This seems to exclude the possibility for hypothesis tests involving a likelihood function evaluated using a PDF with dimensionality greater than 1 which, in my naive understanding, is a desirable use-case for this calculator.
Thanks for all your work!
Hey, that's a good catch! Indeed, this should be working for n-dims and is not generalized.
Since zfit itself offers now also to directly create binned histograms, this could be the best way to go: https://zfit-tutorials.readthedocs.io/en/latest/tutorials/components/30%20-%20Binned%20models.html#binned-models-from-histograms
Or we could simply generalize it as it is now, the problem is maybe that it only takes the midpoint, which is probably often good enough but maybe creates a small bias.
I suppose either way this will require some development (and a new release!) before I can use it. There is no workaround, right?
Hey, as far as I remember the asymptotic method was only documented for 1D problems (I.e 1D parameter of interest)
You should probably check the papers and see if there is an extension to N-dim.
It's a 1D poi, but that's a different thing to requiring a 1D space for the asimov dataset. The pdf can be multidimensional while the scan is still over a 1 dimensional yield parameter, for example.