Forgotten intercept in SGDRegressor

Hey guys!

Seems that there is a bug in the predict method of SGDRegressor.

Shouldn't intercept_ be added here?

Lines 395 to 406 in b96f9c6

    
           try: 
        
               assert_all_finite(self.coef_) 
        
               pred = safe_sparse_dot(X, self.coef_.T) 
        
           except ValueError: 
        
               n_samples = X.shape[0] 
        
               n_vectors = self.coef_.shape[0] 
        
               pred = np.zeros((n_samples, n_vectors)) 
        
           if not self.outputs_2d_: 
        
               pred = pred.ravel() 
        
           return pred

cf.

lightning/lightning/impl/base.py

Lines 107 to 111 in b96f9c6

    
           def predict(self, X): 
        
               pred = safe_sparse_dot(X, self.coef_.T) 
        
               if hasattr(self, "intercept_"): 
        
                   pred += self.intercept_

Gently ping @mblondel @MechCoder @zermelozf @fabianp

Yep, I think you're right. Thanks for the catch.

	try:
	assert_all_finite(self.coef_)
	pred = safe_sparse_dot(X, self.coef_.T)
	except ValueError:
	n_samples = X.shape[0]
	n_vectors = self.coef_.shape[0]
	pred = np.zeros((n_samples, n_vectors))

	if not self.outputs_2d_:
	pred = pred.ravel()

	return pred

	def predict(self, X):
	pred = safe_sparse_dot(X, self.coef_.T)

	if hasattr(self, "intercept_"):
	pred += self.intercept_