Cocycles with sparse matrices

Question

Cocycles with sparse matrices

dcarmod2 opened this issue 4 years ago · 3 comments

First, thank you for your work on this package!

In ripser.py, the call to DRFDMSparse doesn't pass do_cocycles, meaning do_cocycles is always set to the default value of zero when the input to ripser is a sparse matrix.

I'm not sure if this was on purpose, but some small test cases seem to work fine when editing the .py file to pass the user supplied do_cocycles through.

Answer 1 · 2021-03-29T01:25:32.000Z

Ah, great catch! Would you mind submitting a pull request?

…

On Fri, Mar 26, 2021 at 3:09 AM dcarmod2 ***@***.***> wrote: First, thank you for your work on this package! In ripser.py, the call to DRFDMSparse doesn't pass do_cocycles, meaning do_cocycles is always set to the default value of zero when the input to ripser is a sparse matrix. I'm not sure if this was on purpose, but some small test cases seem to work fine when editing the .py file to pass the user supplied do_cocycles through. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#117>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJWDZUA45ZY7QVDXL4NF5LTFQXIZANCNFSM4Z22XGPA> .

Answer 2 · 2021-03-29T05:19:02.000Z

Sure thing, submitted one

Answer 3 · 2021-03-30T01:40:36.000Z

Thank you again for this, this was a good catch!

…

On Mon, Mar 29, 2021 at 1:19 AM dcarmod2 ***@***.***> wrote: Sure thing, submitted one — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#117 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJWDZUBSFI7LVAOOA32Y6TTGAEVLANCNFSM4Z22XGPA> .